Browse Source

fix logic for updating portfolio

Daniel Bohry 8 months ago
parent
commit
88d417cee0

+ 1 - 1
src/main/java/com/danielbohry/stocks/service/PortfolioService.java

@@ -100,7 +100,7 @@ public class PortfolioService {
         log.info("Updating portfolio [{}]", id);
         PortfolioEntity toUpdate = repository.findById(id).orElseThrow(() -> new NotFoundException("Failed to update portfolio with id: " + id));
 
-        if (!Objects.equals(toUpdate.getUser(), UserContextHolder.get().getId()) || UserContextHolder.isAdmin()) {
+        if (!Objects.equals(toUpdate.getUser(), UserContextHolder.get().getId()) && !UserContextHolder.isAdmin()) {
             throw new UnauthorizedException("You do not have permission to update portfolio");
         }